Tools / TExtraLegendTool broken in TeeChart pro v2014

[dsn]

Hi,

I've been unable to use the TExtraLegendTool recently, regardless of the legend options, the extra legend does not show anywhere on the chart.
After a while, i've realised that the TeeChart Pro demo 2014 exhibits the same behavior.
I might be mistaken, but it looks like a regression no ?
See attached screenshots.
Don't hesitate to contact me for further information,

(Note : i've source code access, if the fix is simple enough, i'll be really interested in a patch to fix this)
Thanks in advance for your help,

Regards,

[dsn]

I forget to mention the version i'm using : TeeChart pro v2014.10.140220.
Thanks in advance,
Regards,

[dsn]

current behavior

multiple_legend_2014.jpg (273.08 KiB) Viewed 18909 times

expected behavior

multiple_legend_2010.jpg (233.92 KiB) Viewed 18896 times

On a side (and probably unrelated note), there seems to be a slight glitch in the legend-canvas drawing stuff
in the latest demo of Multiple Legend in the demo of Tee9New_win32.exe
(GDI+ selection/deselection does not impact the resulting output)

Bottom line is, getting multiple legend is a tricky business in version 2014.10.140220 (VCL)
Thanks in advance for your help,

Regards,

[Yeray]

Hello,

I've been unable to use the TExtraLegendTool recently, regardless of the legend options, the extra legend does not show anywhere on the chart.
After a while, i've realised that the TeeChart Pro demo 2014 exhibits the same behavior.
I might be mistaken, but it looks like a regression no ?

I've reproduced the problem so I've added it to the public tracker:
http://bugs.teechart.net/show_bug.cgi?id=755
Feel free to add your mail to the ticket CC list to be automatically notified when an update on it arrives.

On a side (and probably unrelated note), there seems to be a slight glitch in the legend-canvas drawing stuff
in the latest demo of Multiple Legend in the demo of Tee9New_win32.exe
(GDI+ selection/deselection does not impact the resulting output)

I've also reproduced this and added it to the public tracker:
http://bugs.teechart.net/show_bug.cgi?id=756

Bottom line is, getting multiple legend is a tricky business in version 2014.10.140220 (VCL)

As you'll see, I've found a possible fix for the second. Feel free to implement the change in your sources.

[Bert B.]

This hasn't been fixed already?
Please note that this issue is exactly 1 year old, which is unacceptable in my opinion.

[Yeray]

Hello Bert,

Excuse us for the delayed reply here.
We closed both tickets as "fixed" a week ago:
http://bugs.teechart.net/show_bug.cgi?id=755
http://bugs.teechart.net/show_bug.cgi?id=756

Since you own the sources, you can apply the changes to them and recompile them.
The change is quite simple actually:

- At Chart.pas, move CalcRect from the private section on TCustomChartLegend class to the protected section.
- At TeeExtraLegendTool.pas, call TLegendAccess(Legend).CalcRect before Legend.DrawLegend:

Code: Select all

procedure TExtraLegendTool.ChartEvent(AEvent: TChartToolEvent);
begin
  inherited;
  if (AEvent=cteAfterDraw) then
  begin
    if Assigned(ParentChart) and Assigned(Series) then
    begin
      Legend.Series:=Series; // call getter
      if Legend.Visible then
      begin
        TLegendAccess(Legend).CalcRect;
        Legend.DrawLegend;
      end;
    end;
  end;
end;

[Bert B.]

Hello Yeray,

The fix works fine, thanks.
I am still using version 2014.12.140923 and had to change the TCustomChartLegend class. This class has been renamed since then?

Bert

[Yeray]

Hi Bert,

I am still using version 2014.12.140923 and had to change the TCustomChartLegend class. This class has been renamed since then?

TCustomChartLegend class is defined in Chart.pas unit in the actual sources and also in v2014.12. I'm not sure to understand your doubt.

[Bert B.]

Hello Yeray,

You wrote about a change in the TCustomLegend class but I had to change the TCustomChartLegend class.

Bert

[Yeray]

Hi Bert,

You wrote about a change in the TCustomLegend class but I had to change the TCustomChartLegend class.

I'm sorry, I missed the "Chart" part in the TCustomChartLegend.
I'll edit the post above to correct it.

[cvita]

We do suffer from this issue, too. We need to create a Chart showing a CustomLegend which diesn't show. Unfortunately we do not have the sources.
So my question: when this issue will be fixed for public?
Thanks in advance!
Klaus

[Yeray]

Hi Klaus,

when this issue will be fixed for public?

The next maintenance release should include these fixes. However, I'm afraid I can't tell you when the it will be published.
We'll prepare a test installer and we'll send you a mail with the link to it asap.

[Yeray]

Hi Klaus,

We'll prepare a test installer and we'll send you a mail with the link to it asap.

Could you please tell us what IDE are you interested in?

[cvita]

Hello Yeray!
It would be really great to have this fix ASAP. Thanks for the offer!
We use currently Delphi XE5.
Regards and thanks again,
Klaus

[Yeray]

Hi Klaus,

I've just sent it to the mail account you have registered in this forum.